On Tue, Sep 4, 2012 at 11:35 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Magnus Hagander <mag...@hagander.net> writes: > > On Tue, Sep 4, 2012 at 6:57 AM, Michael Paquier > > <michael.paqu...@gmail.com> wrote: > >> I found some whitespace characters in utility.c introduced by commit > >> 3a0e4d3. > >> Please find attached a patch fixing that which can be applied on > postgres > >> master (commit 2f0c7d5). > > > That probably exists in many other places in the source as well, but > > it's certainly fairly ugly. So I see nothing wrong cleaning it up whe > > nspotted. > > Just as a note: we generally leave it to pgindent to fix this sort of > thing. I'm not sure it's worth the effort of submitting manual patches > for, unless you have reason to think the next pgindent run won't fix it. > Understood, thanks for telling about that. I just read some code and bumped into it, for sure doing such maintenance all at once with pgindent saves time and effort. -- Michael Paquier http://michael.otacoo.com