On Wed, 2012-10-03 at 18:15 +0200, Boszormenyi Zoltan wrote: > The second generation of this work is now attached and contains a new > feature as was discussed and suggested by Magnus Hagander, Fujii Masao > and Peter Eisentraut. So libpq has grown a new function: > > +/* return the connection options used by a live connection */ > +extern PQconninfoOption *PQconninfo(PGconn *conn); > > This copies all the connection parameters back from the live PGconn > itself > so everything that's needed to connect is already validated.
I don't like that this code maintains a second list of all possible libpq connection parameters. The parameters to add to the connection string should be driven off the authoritative list in PQconninfoOptions. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers