> On Monday, October 15, 2012 3:43 PM Heikki Linnakangas wrote: > On 13.10.2012 19:35, Fujii Masao wrote: > > On Thu, Oct 11, 2012 at 11:52 PM, Heikki Linnakangas > > <hlinnakan...@vmware.com> wrote: > >> Ok, thanks. Committed. > > > > I found one typo. The attached patch fixes that typo. > > Thanks, fixed. > > > ISTM you need to update the protocol.sgml because you added > > the field 'replyRequested' to WalSndrMessage and StandbyReplyMessage.
> > > Is it worth adding the same mechanism (send back the reply immediately > > if walsender request a reply) into pg_basebackup and pg_receivexlog? > > Good catch. Yes, they should be taught about this too. I'll look into > doing that too. If you have not started and you don't have objection, I can pickup this to complete it. For both (pg_basebackup and pg_receivexlog), we need to get a timeout parameter from user in command line, as there is no conf file here. New Option can be -t (parameter name can be recvtimeout). The main changes will be in function ReceiveXlogStream(), it is a common function for both Pg_basebackup and pg_receivexlog. Handling will be done in same way as we have done in walreceiver. Suggestions/Comments? With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
