Tom Lane escribió:
> Alvaro Herrera <alvhe...@2ndquadrant.com> writes:
> > I gave this a look. I think it needs to be revised by somebody with a
> > better understanding of scanner (flex) than me, but I didn't like the
> > changes in psqlscan.l at all; the new <xvl> pattern is too unlike the
> > rest of the surrounding patterns, and furthermore it has been placed
> > within the block that says it mirrors the backend scanner, when it
> > obviously has no equivalent there.
>
> > I assume there's a better way to do this. Hints would be appreciated.
>
> Personally I saw no reason for this patch to touch psqlscan.l in the
> first place. Commands such as \set just scan variable names with
> psql_scan_slash_option(OT_NORMAL); why shouldn't this act the same?
>
> Moreover, the proposed lexer rules are flat out *wrong*, in that they
> insist on the target variable names being {identifier}s, a restriction
> not imposed by \set.
Great, thanks for the feedback. Marking as returned in CF. I hope to
see a new version after pgconf.eu.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
