On 11/15/2012 10:11 AM, Robert Haas wrote:

+       {
+               sift_down(heap, i);
+       }

Project style is to omit braces for a single-line body.  This comes up
a few other places as well.


I thought we modified that some years ago, although my memory of it is a bit hazy. Personally I think it's a bad rule, at least as stated, in the case where there's an else clause with a compound statement. I'd prefer to see a rule that says that either both branches of an if/else should be compound statements or neither should be. I think the cases where only one branch is a compound statement are rather ugly.

cheers

andrew



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to