Hi, Thanks for working on that cleanup job!
Kohei KaiGai <kai...@kaigai.gr.jp> writes: > The attached patch is the revised version of ALTER RENAME TO > consolidation. According to the previous suggestion, it uses > a common logic to check object-naming duplication at > check_duplicate_objectname(). I think you need to better comment which object types are supported by the new generic function and which are not in AlterObjectRename(). > At the code path on AlterObjectNamespace_internal, it lost > ObjectType information to the supplied object, so I also added > get_object_type() function at objectaddress.c for inverse > translation from a couple of classId/objectId to OBJECT_* label. I don't understand that part, and it looks like it would be way better to find a way to pass down the information you already have earlier in the code than to compute it again doing syscache lookups… Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
