On Wed, Nov 21, 2012 at 1:30 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > The following comments still talk about "key and value", thus need > an update:
Oops. > This comment needs updated (s/comparator/compare/, and also add > has_heap_property and arg): Fixed. > I would suggest to add prefixes to struct members, so bh_size, bh_space > and so on. This makes it easier to grep for stuff later. OK. > Do we really need the struct definition be public? Couldn't it just > live in binaryheap.c? Well, that would preclude defining any macros, like binaryheap_empty(). Since efficiency is among the reasons for inventing this in the first place, that doesn't seem prudent to me. Another new version attached. P.S. to Abhijit: Please, please tell me the secret to getting five people to review your patches. I'm lucky when I can get one! -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
binaryheap-rmh3.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
