On 2012-11-27 12:50:36 -0500, Tom Lane wrote: > Andres Freund <and...@2ndquadrant.com> writes: > > I vote for introducing wrapper functions/macro to do the > > about-to-be-dropped check, its hard enough to understand as-is. > > Meh. If it's only going to be done in RelationGetIndexList, I'm > not sure that a wrapper macro is worth the trouble. If we needed > the test in multiple places I'd agree, but what other spots do you > see?
I don't really see any other querying locations - but such a macro would make the code easier backpatchable when we introduce a third column for the about-to-be-dropped case. Anyway, don't feel all too strongly about it. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
