On 12/12/12 20:21, Karl O. Pinc wrote:
There were 2 outstanding issue raised:
Is this useful enough/proceeding in the right direction to commit
now?
Should some of the logic be moved out of a subroutine and into the
calling code?
I can see arguments to be made for both sides. I'm asking that you
think it through to the extent you deem necessary and make
changes or not. At that point it should be ready to send
to a committer. (I'll re-test first, if you make any changes.)
Oh my, I have dropped the ball on this one in the worst manner possible.
Sorry!
I actually still prefer to keep the signatures of PLy_get_spi_sqlerrcode
and PLy_get_spi_error_data similar, so I'd opt for keeping the patch
as-is :)
Thanks,
Jan
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
