2013/1/14 Tom Lane <t...@sss.pgh.pa.us>: > Pavel Stehule <pavel.steh...@gmail.com> writes: >> this is very simple patch - it enables hidden_queries for commands >> \sf and \ef to be consistent with other describing commands. > > So far as I can tell, get_create_function_cmd (and lookup_function_oid > too) were intentionally designed to not show their queries, and for that > matter they go out of their way to produce terse error output if they > fail. I'm not sure why we should revisit that choice. In any case > it seems silly to change one and not the other.
Motivation for this patch is consistency with other backslash statements. Some people uses --echo-hidden option like "tutorial" or "navigation" over system tables or builtin functionality. With this patch these people should be navigated to function pg_get_functiondef. There are no other motivation - jut it should to help to users that has no necessary knowledges look to psql source code. I am not sure about --echo-hidden option - if it is limited just to system tables or complete functionality. Probably both designs are valid. So first we should to decide if this behave is bug or not. I am co-author \sf and I didn't calculate with --echo-hidden options. Now I am inclined so it is bug. This bug is not significant - it is just one detail - but for some who will work with psql this can be pleasant feature if psql will be consistent in all. After decision I can recheck this patch and enhance it for all statements. Regards Pavel > > A purely stylistic gripe is that you have get_create_function_cmd taking > a PGconn parameter that now has nothing to do with its behavior. > > regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
