Stephen Frost <sfr...@snowman.net> writes: > * Ali Dar (ali.munir....@gmail.com) wrote: >> Find attached an initial patch for ALTER RENAME RULE feature. Please >> note that it does not have any documentation yet.
> Just took a quick look through this. Seems to be alright, but why do we > allow renaming ON SELECT rules at all, given that they must be named > _RETURN? My thinking would be to check for that case and error out if > someone tries it. Agreed, we should exclude ON SELECT rules. > You should try to keep variables lined up: pgindent is probably a better answer than trying to get this right manually. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers