On Saturday, January 19, 2013 2:37 AM Boszormenyi Zoltan wrote: 2013-01-18 21:48 keltezéssel, Boszormenyi Zoltan írta: > 2013-01-18 21:32 keltezéssel, Tom Lane írta: >> Boszormenyi Zoltan <z...@cybertec.at> writes: >>> 2013-01-18 11:05 keltezéssel, Amit kapila írta: >>>>> On using mktemp, linux compilation gives below warning >>>>> warning: the use of `mktemp' is dangerous, better use `mkstemp' >>>> >>>>> So I planned to use mkstemp. >>>> Good. >>> On my HPUX box, the man page disapproves of both, calling them obsolete >>> (and this man page is old enough to vote, I believe...)
>Then we have to at least consider what this old {p|s}age says... ;-) >> >>> Everywhere else that we need to do something like this, we just use our >>> own PID to disambiguate, ie >>> sprintf(tempfilename, "/path/to/file.%d", (int) getpid()); >>> There is no need to deviate from that pattern or introduce portability >>> issues, since we can reasonably assume that no non-Postgres programs are >>> creating files in this directory. > >> Thanks for the enlightenment, I will post a new version soon. > Here it is. Thanks a ton for providing better modified version. I shall test it on Monday once and then we can conclude on it. The only point in modifications, I am not comfortable is that in error messages you have mentioned (automatic configuration directory). I am not sure if we should use work "automatic" for config_dir or just use configuration directory. However I shall keep as it is if no one else has any objection. We can let committer decide about it. With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers