Tom Lane wrote: > Andres Freund <and...@2ndquadrant.com> writes: > > On 2013-01-18 10:33:16 -0500, Tom Lane wrote: > >> Really I'd prefer not to move the backend definitions out of postgres.h > >> at all, just because doing so will lose fifteen years of git history > >> about those particular lines (or at least make it a lot harder to > >> locate with git blame). > > > The alternative seems to be sprinkling a few more #ifdef FRONTEND's in > > postgres.h, if thats preferred I can prepare a patch for that although I > > prefer my proposal. > > Yeah, surrounding the existing definitions with #ifndef FRONTEND was > what I was imagining. But on reflection that seems pretty darn ugly, > especially if the corresponding FRONTEND definitions are far away. > Maybe we should just live with the git history disconnect. > > Right at the moment the c.h location seems like the best bet.
Since there seems to be consensus that this is the best way to go, I have committed it. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
