Peter Eisentraut wrote:
> pg_resetxlog uses a non-standard options parsing method: The -l option
> requires two arguments (-l fileid seg).  I propose to change this to -l
> fileid,seg which is the standard way to separate suboptions.

Agreed.

> Secondly, the -n option appears to be redundant with pg_controldata.  Do
> we need it?

Yep.

> Thirdly, pg_resetxlog uses the term "guessed" controldata values if it
> can't read the real ones.  I found this to be confusing, because the code
> doesn't do a whole lot of guessing.  Would it be better to say that the
> values are simply defaulted (and to what)?

"Attempts to determine the proper values"?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  [EMAIL PROTECTED]               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org

Reply via email to