Jeff Janes escribió: > On Mon, Feb 18, 2013 at 7:50 AM, Alvaro Herrera > <alvhe...@2ndquadrant.com> wrote: > > > > So here's v11. I intend to commit this shortly. (I wanted to get it > > out before lunch, but I introduced a silly bug that took me a bit to > > fix.) > > On Windows with Mingw I get this: > > pgstat.c:4389:8: warning: variable 'found' set but not used > [-Wunused-but-set-variable] > > I don't get that on Linux, but I bet that is just the gcc version > (4.6.2 vs 4.4.6) rather than the OS. It looks like it is just a > useless variable, rather than any possible cause of the Windows "make > check" failure (which I can't reproduce).
Hm, I remember looking at that code and thinking that the "return" there might not be the best idea because it'd miss running the code that checks for clock skew; and so the "found" was necessary because the return was to be taken out. But on second thought, a database for which the loop terminates early has already run the clock-skew detection code recently, so that's probably not worth worrying about. IOW I will just remove that variable. Thanks for the notice. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
