On 2013-02-23 14:54:51 -0800, Jeff Janes wrote: > If I run "make clean", or "make maintainer-clean", this deletes the file > contrib/pg_xlogdump/rmgrdesc.c. And then config/make doesn't know how to > get it back again. > > I don't know if the Makefile needs to be taught not to delete it, or taught > how to recreate it once deleted.
It shouldn't be deleted, I think neither Alvaro nor me did notice this because it only matters in non-vpath builds... Patch attached. I independently wonder whether we should remove the PGXS stub from xlogdump, given it relies on a full sourcetree available? Andres -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
diff --git a/contrib/pg_xlogdump/Makefile b/contrib/pg_xlogdump/Makefile index f381967..b454c02 100644 --- a/contrib/pg_xlogdump/Makefile +++ b/contrib/pg_xlogdump/Makefile @@ -1,7 +1,7 @@ # contrib/pg_xlogdump/Makefile PGFILEDESC = "pg_xlogdump" -PGAPPICON=win32 +PGAPPICON = win32 PROGRAM = pg_xlogdump OBJS = pg_xlogdump.o compat.o xlogreader.o rmgrdesc.o \ @@ -10,7 +10,7 @@ OBJS = pg_xlogdump.o compat.o xlogreader.o rmgrdesc.o \ RMGRDESCSOURCES = $(notdir $(wildcard $(top_srcdir)/src/backend/access/rmgrdesc/*desc.c)) RMGRDESCOBJS = $(patsubst %.c,%.o,$(RMGRDESCSOURCES)) -EXTRA_CLEAN = $(RMGRDESCSOURCES) xlogreader.c rmgrdesc.c +EXTRA_CLEAN = $(RMGRDESCSOURCES) xlogreader.c ifdef USE_PGXS PG_CONFIG = pg_config @@ -25,7 +25,7 @@ endif override CPPFLAGS := -DFRONTEND $(CPPFLAGS) -rmgrdesc.c xlogreader.c: % : $(top_srcdir)/src/backend/access/transam/% +xlogreader.c: % : $(top_srcdir)/src/backend/access/transam/% rm -f $@ && $(LN_S) $< . $(RMGRDESCSOURCES): % : $(top_srcdir)/src/backend/access/rmgrdesc/%
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
