On Monday, February 25, 2013 11:26 PM Heikki Linnakangas wrote: > On 21.02.2013 16:09, Amit Kapila wrote: > > On Thursday, February 21, 2013 12:46 AM Heikki Linnakangas wrote: > I've committed those patches, with some further changes. If you have > the > time, please take another look at the committed patches. Thanks!
1. For pg_dumpall, incase user gives dbname in connection string, for ex. "user=amit dbname=db_regress port=5434" it will be ignored and postgres (default database name) will be used. 2. For pg_basebackup, no need to check if(conn_opts) before PQconninfoFree as it will internally take care of NULL. This will not cause any harm, just an observation. With Regards, Amit Kapila -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
