I'm starting to review this patch now, and I'm having a hard time with this particular design decision:
Amit Kapila <[email protected]> writes: > We cannot directly compare expressions in target list as even if expressions > are equal, below node (ex. APPEND) will > not do projection, and hence expr will not be evaluated. I think this is nonsense. Whatever the tlist of the lower node is, that is supposed to describe what it's going to return. That node might not be able to do projection, but that doesn't mean that something underneath it didn't. So I think this patch is missing a bet by not accepting equal() expressions. Did you have a test case showing that this wouldn't work? regards, tom lane -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
