Please find attached the patches wanted: - 20130317_reindexdb_concurrently.patch, adding an option -c/--concurrently to reindexdb Note that I added an error inside reindexdb for options "-s -c" as REINDEX CONCURRENTLY does not support SYSTEM. - 20130317_dump_only_valid_index.patch, a 1-line patch that makes pg_dump not take a dump of invalid indexes. This patch can be backpatched to 9.0.
On Sun, Mar 17, 2013 at 3:31 AM, Michael Paquier <michael.paqu...@gmail.com>wrote: > On 2013/03/17, at 0:35, Fujii Masao <masao.fu...@gmail.com> wrote: > > > On Wed, Mar 13, 2013 at 9:04 PM, Michael Paquier > > I found pg_dump dumps even the invalid index. But pg_dump should > > ignore the invalid index? > > This problem exists even without REINDEX CONCURRENTLY patch. So we might > need to > > implement the bugfix patch separately rather than including the bugfix > > code in your patches. > > Probably the backport would be required. Thought? > Hum... Indeed, they shouldn't be included... Perhaps this is already known? > Note that there have been some recent discussions about that. This *problem* also concerned pg_upgrade. http://www.postgresql.org/message-id/20121207141236.gb4...@alvh.no-ip.org -- Michael
20130317_reindexdb_concurrently.patch
Description: Binary data
20130317_dump_only_valid_index.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers