Heikki Linnakangas wrote: > This is what I came up with. I created a new file, misc.c (for lack > of a better name), for things that are shared by pg_dump and > pg_restore, but not pg_dumpall or other programs. I moved all the > parallel stuff from dumputils.c to parallel.c, and everything else > that's not used outside pg_dump and pg_restore to misc.c. I moved > exit_horribly() to parallel.c, because it needs to do things > differently in parallel mode.
Not happy with misc.c as a filename. How about pg_dump_utils.c or pg_dump_misc.c? I think the comment at the top should explicitely say that the file is intended not to be linked in pg_dumpall. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
