Hi, Please find attached the updated patch.
Fabien pointed out that currently does not check for non-trivial locales. I am still on the learning curve about LOCALEs and so, let me know if this is a show-stopper. I guess I could look at it and get back in some time with more tests as Fabien points out. (Apologies for the delay though. An update to the patch was mostly done back in April, but since most of the other Code-Coverage patches (SCHEMA/ROLE/etc.) had no other feedback, I worked on all of them together just this week). -- Robins Tharakan On 12 April 2013 09:28, Michael Paquier <michael.paqu...@gmail.com> wrote: > > > > On Thu, Apr 11, 2013 at 4:14 PM, Robins Tharakan <thara...@gmail.com>wrote: > >> Hi, >> >> Please find attached a patch to take 'make check' code-coverage of >> COLLATE (/src/backend/commands/collationcmds) from 0% to 96%. >> >> Any feedback is more than welcome. Also posting this to Commitfest-next. >> > Just by having a quick look at the patch, using object names of the type > cX is too generic even if the tests are done in a private schema. Why not > using a name like collate_obj_X or similar? > -- > Michael >
regress_collate_v2.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
