On Saturday, May 25, 2013 12:50 AM Alvaro Herrera wrote: > Hi,
> While going through Andres' BDR code I noticed that it has a shmem > startup hook, which installs a on_shmem_exit() callback to write stuff > at shutdown time. This works fine but seems somewhat of a hazard: it is > having postmaster do the actual write, which has to access shared memory > while doing it. Moreover, since the callback is installed to be called > at shmem reset, it means that a process crash causes this code to be > called, which seems similarly broken. > It seems that the right place to do this is checkpointer shutdown, i.e. > when checkpointer is told to close shop it should also invoke various > modules' shutdown callbacks. There's no hook point there though, so > we'd need to introduce something new for this specific purpose. Do you mean to say that during shutdown of checkpoint, it should call interface which does same as shmem_exit() which means call shutdown callbacks of other modules? Why would checkpointer shutdown is better place to handle? With Regards, Amit Kapila. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
