On 2013-06-08 13:26:56 -0700, Joshua D. Drake wrote: > >At the points where the XLogInsert()s happens we're in critical sections > >out of which we *cannot* ERROR out because we already may have made > >modifications that cannot be allowed to be performed > >partially/unlogged. That's why we're throwing a PANIC which will force a > >cluster wide restart including *NOT* writing any further buffers from > >s_b out. > > > > Does this preclude (sorry I don't know this part of the code very well) my > suggestion of on log create?
Well, yes. We create log segments some layers below XLogInsert() if necesary, and as I said above, we're in a critical section at that point, so just rolling back isn't one of the options. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
