Le samedi 15 juin 2013 23:45:21, Andrew Dunstan a écrit : > On 06/15/2013 02:43 PM, David E. Wheeler wrote: > > On Jun 15, 2013, at 4:12 AM, Andrew Dunstan <and...@dunslane.net> wrote: > >> REGRESS_OPTS = --inputdir=test --outputdir=test \ > >> > >> --load-extension=$(EXTENSION) > >> > >> ... > >> override pg_regress_clean_files = test/results/ > >> test/regression.diffs test/regression.out tmp_check/ log/ > >> > >> That keeps the testing stuff out of the way quite nicely. > > > > I don't suppose there could be a way for the makefile to notice the > > --outputdir option and add those files to the clean target itself, could > > there? Having it hard-coded is slightly annoying. Maybe it could ask > > pg_regress where to find them? > > That doesn't sound like a promising line of development to me. Better > would be to provide a PGXS option to specify where tests are based, and > set the clean target accordingly. > > Then instead of the above you'd just be able to say something like > > MODULETEST = test
or REGRESSDIR ? Also I suggest to remove the need to set REGRESS at all, and default to all sql files in REGRESSDIR/sql (if REGRESSDIR is set) Back to DOCS, we may also have PGXS default to find a README(.*) and rename it to README.$extension.$1 if MODULEDIR is not set. > REGRESS_OPTS = --load-extension=$(EXTENSION) > > Which would be a good deal cleaner. yes. -- Cédric Villemain +33 (0)6 20 30 22 52 http://2ndQuadrant.fr/ PostgreSQL: Support 24x7 - Développement, Expertise et Formation
signature.asc
Description: This is a digitally signed message part.
