On 2013-06-21 02:43:23 -0700, Hitoshi Harada wrote: > On Fri, Jun 21, 2013 at 2:20 AM, Hitoshi Harada <umi.tan...@gmail.com>wrote: > > > > > > > > > On Fri, Jun 14, 2013 at 9:05 AM, Kevin Grittner <kgri...@ymail.com> wrote: > > > >> Attached is a patch for REFRESH MATERIALIZED VIEW CONCURRENTLY for > >> 9.4 CF1. The goal of this patch is to allow a refresh without > >> interfering with concurrent reads, using transactional semantics. > >> > > > > I spent a few hours to review the patch. > > > > Oh, BTW, though it is not part of this patch, but I came across this. > > ! /* > ! * We're not using materialized views in the system catalogs. > ! */ > Assert(!IsSystemRelation(matviewRel)); > > Of course we don't have builtin matview on system catalog, but it is > possible to create such one by allow_system_table_mods=true, so Assert > doesn't look like good to me.
Anybody using allow_system_table_mods gets to keep the pieces. There are so many ways to break just about everything things using it that I don't think worrying much makes sense. If you want you could replace that by an elog(), but... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
