On 2013-06-23 08:27:32 -0700, Kevin Grittner wrote: > Kevin Grittner <kgri...@ymail.com> wrote: > > > Confirmed that all 17 patch files now apply cleanly, and that `make > > check-world` builds cleanly after each patch in turn. > > Just to be paranoid, I did one last build with all 17 patch files > applied to 7dfd5cd21c0091e467b16b31a10e20bbedd0a836 using this > line: > > make maintainer-clean ; ./configure --prefix=$PWD/Debug --enable-debug > --enable-cassert --enable-depend --with-libxml --with-libxslt --with-openssl > --with-perl --with-python && make -j4 world > > and it died with this: > > gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith > -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute > -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g > -I../../../src/interfaces/libpq -I../../../src/include -D_GNU_SOURCE > -I/usr/include/libxml2 -c -o pg_receivexlog.o pg_receivexlog.c -MMD -MP -MF > .deps/pg_receivexlog.Po > gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith > -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute > -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g > -I. -I. -I../../../src/interfaces/libpq -I../../../src/bin/pg_dump > -I../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2 -c -o > mainloop.o mainloop.c -MMD -MP -MF .deps/mainloop.Po > gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith > -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute > -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g > pg_receivellog.o receivelog.o streamutil.o -L../../../src/port -lpgport > -L../../../src/common -lpgcommon -L../../../src/interfaces/libpq -lpq > -L../../../src/port -L../../../src/common -L/usr/lib -Wl,--as-needed > -Wl,-rpath,'/home/kgrittn/pg/master/Debug/lib',--enable-new-dtags -lpgport > -lpgcommon -lxslt -lxml2 -lssl -lcrypto -lz -lreadline -lcrypt -ldl -lm -o > pg_receivellog > gcc: error: pg_receivellog.o: No such file or directory > make[3]: *** [pg_receivellog] Error 1 > make[3]: Leaving directory `/home/kgrittn/pg/master/src/bin/pg_basebackup' > make[2]: *** [all-pg_basebackup-recurse] Error 2 > make[2]: *** Waiting for unfinished jobs....
I have seen that once as well. It's really rather strange since pg_receivellog.o is a clear prerequisite for pg_receivellog. I couldn't reproduce it reliably though, even after doing some dozen rebuilds or so. > It works with this patch-on-patch: > diff --git a/src/bin/pg_basebackup/Makefile b/src/bin/pg_basebackup/Makefile > index a41b73c..18d02f3 100644 > --- a/src/bin/pg_basebackup/Makefile > +++ b/src/bin/pg_basebackup/Makefile > @@ -42,6 +42,7 @@ installdirs: > uninstall: > rm -f '$(DESTDIR)$(bindir)/pg_basebackup$(X)' > rm -f '$(DESTDIR)$(bindir)/pg_receivexlog$(X)' > + rm -f '$(DESTDIR)$(bindir)/pg_receivellog$(X)' > > clean distclean maintainer-clean: > - rm -f pg_basebackup$(X) pg_receivexlog$(X) $(OBJS) pg_basebackup.o > pg_receivexlog.o pg_receivellog.o > + rm -f pg_basebackup$(X) pg_receivexlog$(X) pg_receivellog$(X) $(OBJS) > pg_basebackup.o pg_receivexlog.o pg_receivellog.o > > It appears to be an omission from file 0015. Yes, both are missing. > > + rm -f '$(DESTDIR)$(bindir)/pg_receivellog$(X)' > Oops. That part is not needed. Hm. Why not? I don't think either hunk has anything to do with that buildfailure though - can you reproduce the error without? Thanks, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
