OK, I like this idea a lot, but I have a question.  Right now, to use
this, you have to supply the startup SQL on the command line.  And
that could definitely be useful.  But ISTM that you might also want to
take the startup SQL from a file, and indeed you might well want to
include metacommands in there.  Maybe that's getting greedy, but the
rate at which people are adding features to pgbench suggests to me
that it won't be long before this isn't enough.

Thoughts?

My 0.02€:

I thought about this point while reviewing the patch, but I did not add it to the review because ISTM that it would require a lot of changes, and pgbench is already kind of a mess, IMHO. Also, possibly you would like to use a script under different assumptions to test them, that would require the startup string to be out of the script so as to change it easily. So it would not be that useful.

--
Fabien.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to