On Tue, Jun 25, 2013 at 2:28 AM, Hari Babu <haribabu.ko...@huawei.com> wrote: > Please find the review of the patch.
Thank you for reviewing! > Code Review: > ------------ > +if (orig_post_opts) { > + post_opts = strip_datadirs(orig_post_opts); > +} > > No need of "{}" as the only one statement block is present in the if block. OK. > + free(tmp); > > The above statement can be moved inside the if (*(trailing_quote + 1) != > '\0') { > where it's exact usage is present. Right. > Testing: > -------- > I tested this feature with different postmaster options and database folder > names, found no problem. > > > The database folder with quotes present in it is any way having problems > with pg_ctl. > I feel the strip_datadirs() function header explanation is providing good > understanding. > Overall the patch is good. It makes the pg_ctl restart functionality works > well. Thanks for the feedback. Attached is a rebased version of the patch with the two small issues noted fixed. Josh
pgctl_paths.v02.diff
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers