On Sun, Jun 30, 2013 at 11:13 AM, Pavel Stehule <pavel.steh...@gmail.com>wrote:
> Hello > > just one small notices > > I dislike a name "root_bool_expr", because, there is not a expression, > but expression type. Can you use "root_bool_expr_type" instead? It is > little bit longer, but more correct. Same not best name is > "root_char", maybe "root_bool_op_name" > > or root_expr_type and root_op_name ??? > How about naming those 3 variables as follows: root_expr_kind root_expr_name root_bool_expr_type -- Gurjeet Singh http://gurjeet.singh.im/ EnterpriseDB Inc.