I've looked this version.
The only reservation I have is that when changing the owner of a schema, the new owner is not always checked. I would suggest to query the new owner to check that it matches (5, 11, 12), just as you do in 3.
Also, reowning is tested several times (5, 11, 12). I would suggest to remove 12 which does not bring much new things after both 5 and 11 get passed ?
Otherwise the patch applies (with a minor warning about spaces on line 33) passes for me, and brings valuable new test coverage.
-- Fabien. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
