On Wed, Jul 24, 2013 at 1:50 PM, Greg Stark <st...@mit.edu> wrote: > On Wed, Jul 24, 2013 at 6:39 PM, Robert Haas <robertmh...@gmail.com> wrote: >> This patch will introduce, without documentation, a fifth class of >> keyword. ORDINALITY will need to be quoted when, and only when, it >> immediately follows WITH. Without some change to our deparsing code, >> this is a dump/restore hazard; and with some such change it's still >> probably not a good idea. > > Strictly speaking this patc doesn't introduce this fifth class of > keyword. We already had TIME in that category (and also FIRST and LAST > in a similar category following NULLS). If we have a solution for WITH > <keyword> then presumably we would implement it for WITH TIME and WITH > ORDINALITY at the same time. > > In the interim I suppose we could teach pg_dump to quote any keyword > that follows WITH or NULLS pretty easily. Or just quote those four > words unconditionally.
Making these keywords reserved-enough they get quoted would indeed fix the problem. It may not be desirable for other reasons, but the fact that we have existing cases where pg_dump DTWT doesn't seem like a good reason to add more of them. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
