Peter Eisentraut <pete...@gmx.net> writes:
> make -C pg_upgrade_support all

Do we have something automated to easily test pg_upgrade?

My memories of how pg_upgrade works with extensions makes me believe
that I don't have anything special to do when those extensions have been
made available through a template: the scripts are not used. That said,
we want to retain some new dependencies…

The contrib/pg_upgrade/IMPLEMENTATION file is silent about upgrading
extensions…
            
I fixed the pg_upgrade_support compiling in my branch here, please find
the patch-on-patch attached. I also checked that the whole of contribs
now build fine and didn't find any other problem.

Regards,
-- 
Dimitri Fontaine                                        06 63 07 10 78
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support

commit 71e19099ab935413211e0e1b63529bc71eff7bd9
Author: Dimitri Fontaine <dimi...@2ndquadrant.fr>
Date:   Wed Aug 28 11:40:27 2013 +0200

    Fix compiling contrib/pg_upgrade_support

diff --git a/contrib/pg_upgrade_support/pg_upgrade_support.c b/contrib/pg_upgrade_support/pg_upgrade_support.c
index 99e64c4..efb75a7 100644
--- a/contrib/pg_upgrade_support/pg_upgrade_support.c
+++ b/contrib/pg_upgrade_support/pg_upgrade_support.c
@@ -190,7 +190,8 @@ create_empty_extension(PG_FUNCTION_ARGS)
 						 text_to_cstring(extVersion),
 						 extConfig,
 						 extCondition,
-						 requiredExtensions);
+						 requiredExtensions,
+						 InvalidOid);
 
 	PG_RETURN_VOID();
 }
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to