On 2013-08-28 14:04:59 -0400, Robert Haas wrote:
> >> +  <function>RegisterDynamicBackgroundWorker(<type>BackgroundWorker
> >> +  *worker, BackgroundWorkerHandle **handle</type>)</function>.  Unlike
> >> +  <function>RegisterBackgroundWorker</>, which can only be called from 
> >> within
> >> +  the postmaster, <function>RegisterDynamicBackgroundWorker</function> 
> >> must be
> >> +  called from a regular backend.
> >>   </para>
> >
> > s/which can only be called from within the posmaster/during initial
> > startup, via shared_preload_libraries/?
> 
> This seems like a possible doc clarification not intimately related to
> the patch at hand.  The only reason that paragraph is getting reflowed
> is because of the additional argument to
> RegisterDynamicBackgroundWorker().  On the substance, I could go
> either way on whether your proposed text is better than what's there
> now.

I agree it's unrelated. I just noticed because it was in the diff ;)

> It seems like it might need a bit of wordsmithing, anyway.

Yes, looks like it could use some. It's not going to be me doing it
tho...

Greetings,

Andres Freund

-- 
 Andres Freund                     http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to