On 09/03/2013 06:56 PM, Alvaro Herrera wrote: >> + /* >> + * Only the following suffixes are allowed. It's not >> too useful to >> + * restrict the rate to gigabytes: such a rate will >> probably bring >> + * significant impact on the master anyway, so the >> throttling >> + * won't help much. >> + */ >> + case 'g': >> + factor <<= 10; > > I don't understand why you allow a 'g' here, given the comment above ... > but in any case it should be G. >
This reflects my hesitation whether GB should be accepted as a unit or not. I'll probably remove this suffix. (Will fix the other findings too,) Thanks, Tony -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
