Le lundi 23 septembre 2013 11:43:13 Andrew Dunstan a écrit : > On 09/23/2013 11:31 AM, Alvaro Herrera wrote: > > Marti Raudsepp wrote: > >> On Fri, Sep 13, 2013 at 8:17 PM, Marti Raudsepp <ma...@juffo.org> wrote: > >>> Oh I see, indeed commit 6697aa2bc25c83b88d6165340348a31328c35de6 > >>> "Improve support for building PGXS modules with VPATH" fixes the > >>> problem and I see it's not present in REL9_3_0. > >>> > >>> Andrew and others, does this seem safe enough to backport to > >>> 9.3.1? > >> > >> Ping? Will this be backported to 9.3 or should I report to > >> extension > >> authors to fix their Makefiles? > > > > I think this should be backpatched. > > I'm working on it. It appears to have a slight problem or two I want > to fix at the same time, rather than backpatch something broken.
Would you mind sharing the problems you are facing ? You've noticed the problem about installdirs, I suppose. The attached patch is the fix currently applyed at debian. -- Cédric Villemain +33 (0)6 20 30 22 52 http://2ndQuadrant.fr/ PostgreSQL: Support 24x7 - Développement, Expertise et Formation
Make the install targets depend on installdirs (not yet upstream, tbd) --- a/src/makefiles/pgxs.mk +++ b/src/makefiles/pgxs.mk @@ -132,29 +132,29 @@ $(INSTALL_PROGRAM) $(PROGRAM)$(X) '$(DESTDIR)$(bindir)' endif # PROGRAM -installcontrol: $(addsuffix .control, $(EXTENSION)) +installcontrol: $(addsuffix .control, $(EXTENSION)) | installdirs ifneq (,$(EXTENSION)) $(INSTALL_DATA) $^ '$(DESTDIR)$(datadir)/extension/' endif -installdata: $(DATA) $(DATA_built) +installdata: $(DATA) $(DATA_built) | installdirs ifneq (,$(DATA)$(DATA_built)) $(INSTALL_DATA) $^ '$(DESTDIR)$(datadir)/$(datamoduledir)/' endif -installdatatsearch: $(DATA_TSEARCH) +installdatatsearch: $(DATA_TSEARCH) | installdirs ifneq (,$(DATA_TSEARCH)) $(INSTALL_DATA) $^ '$(DESTDIR)$(datadir)/tsearch_data/' endif -installdocs: $(DOCS) +installdocs: $(DOCS) | installdirs ifdef DOCS ifdef docdir $(INSTALL_DATA) $^ '$(DESTDIR)$(docdir)/$(docmoduledir)/' endif # docdir endif # DOCS -installscripts: $(SCRIPTS) $(SCRIPTS_built) +installscripts: $(SCRIPTS) $(SCRIPTS_built) | installdirs ifdef SCRIPTS $(INSTALL_SCRIPT) $^ '$(DESTDIR)$(bindir)/' endif # SCRIPTS
signature.asc
Description: This is a digitally signed message part.
