On 2013-10-01 11:15:36 -0400, Bruce Momjian wrote: > I see a few cases of this code in src/backend/utils/adt/datetime.c: > > else if ((fmask & DTK_DATE_M) != DTK_DATE_M) > > Wouldn't this be clearer as: > > else if (fmask & DTK_DATE_M)
That doesn't have the same meaning. The latter is trueif only one bit of DTK_DATE_M is set, while the former requires all bits to be set. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers