On Sat, Oct 12, 2013 at 2:58 AM, Alvaro Herrera <alvhe...@2ndquadrant.com>wrote:
> Peter Eisentraut escribió: > > On Tue, 2013-09-17 at 15:13 +0500, Asif Naeem wrote: > > > I did put some time review the patch, please see my findings below > > > i.e. > > > > Updated patch for this. > > Looks good to me. > > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=5b6d08cd2992922b667564a49f19580f11676050 This commit is has broken the visual studios windows build. I'm looking into it now 31 errors similar to: "D:\Postgres\c\pgsql.sln" (default target) (1) -> "D:\Postgres\c\pg_archivecleanup.vcxproj" (default target) (56) -> libpgport.lib(asprintf.obj) : error LNK2019: unresolved external symbol _va_copy referenced in function _vasprintf [D:\Postgres\c\pg_archivecleanup.vcxproj] .\Release\pg_archivecleanup\pg_archivecleanup.exe : fatal error LNK1120: 1 unresolved externals [D:\Postgres\c\pg_archivecleanup.vcxproj] Regards David Rowley -- > Álvaro Herrera http://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Training & Services > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers >
