On Wed, Oct 30, 2013 at 10:16:57AM +0530, Abhijit Menon-Sen wrote: > At 2013-10-24 16:06:19 +0300, hlinnakan...@vmware.com wrote: > > > > Let's get rid of the rounding. > > I share Andres's concern that the bug is present in various recent > kernels that are going to stick around for quite some time. Given > the rather significant performance gain, I think it's worth doing > something, though I'm not a big fan of the directory-scanning code > myself. > > As a compromise, perhaps we can unconditionally round the size up to be > a multiple of 2MB?
How about documenting that 2MB is the quantum (OK, we'll say "indivisible unit" or "smallest division" or something) and failing with a message to that effect if someone tries to set it otherwise? Cheers, David. -- David Fetter <da...@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fet...@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
