On Thu, Nov 7, 2013 at 9:14 AM, Steve Crawford <scrawf...@pinpointresearch.com> wrote: > Due to a variety of messages over time regarding perceived weirdness in > to_timestamp and to_date, this patch adds "(see notes)" in the description > column for to_date and to_timestamp in the Formatting Functions table and > adds the following text to the opening of the usage notes for date/time > conversion: > > The to_date and to_timestamp functions exist to handle unusual input formats > that cannot be converted by simple casting. These functions interpret input > liberally and with minimal error checking and while they will produce valid > output, the conversion has the potential to yield unexpected results. Read > the following notes and test carefully before use. Casting is the preferred > method of conversion wherever possible. > > It also adds the following usage note: > > Input to to_date and to_timestamp is not restricted to normal ranges thus > to_date('20096040','YYYYMMDD') returns 2014-01-17 rather than causing an > error. > > This is the first patch I have submitted directly. Please advise if I have > made any errors in method, style, etc. Sure. You should do the following things: - attach a proper patch to the email you are sending such as people can easily download it and have a look at it without having to regenerate it themselves - submit it to the next commit fest if you want to have it reviewed: https://commitfest.postgresql.org/action/commitfest_view?id=20. Next commit fest begins on the 15th of November and your patch is simple, so for sure somebody will show up and have a closer look at it.
Here are as well general guidelines about patch submission: http://wiki.postgresql.org/wiki/Submitting_a_Patch Regards, -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers