On Thu, Nov 7, 2013 at 11:43 AM, David Rowley <dgrowle...@gmail.com> wrote: > Attached is a small patch which fixes the unused variable warning in the > visual studios build. Seems like VS does not support > __attribute__((unused)) but looks like all other places we must assign to > the variable.
I have raised same issue some time back, see the below link where there is some discussion about it. http://www.postgresql.org/message-id/caa4ek1jeoa1hjgauwpcqhw8av7zapkdxjdwubwetjomi2f8...@mail.gmail.com I think it is good, if one of committer's who have windows env. can look into it and commit or provide suggestions, else you can make a combined patch of this and other warning you saw on windows and upload to next CF so that it doesn't get lost. I checked that you have already submitted a patch for this warning alone in CF. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers