On Wed, Nov 13, 2013 at 9:37 PM, Josh Berkus <j...@agliodbs.com> wrote:
> > handyrep@john:~/handyrep$ pg_isready --version > pg_isready (PostgreSQL) 9.3.1 > > handyrep@john:~/handyrep$ pg_isready -h john -p 5432 -U postgres -d > postgres -q > pg_isready: missing "=" after "postgres" in connection info string > > handyrep@john:~/handyrep$ pg_isready --host=john --port=5432 > --user=postgres --dbname=postgres > pg_isready: missing "=" after "postgres" in connection info string > > handyrep@john:~/handyrep$ pg_isready -h john -p 5432 -U postgres > john:5432 - accepting connections > > so apparently the -d option: > > a) doesn't work, and > b) doesn't do anything > > I suggest simply removing it from the utility. > > I'll note that the -U option doesn't appear to do anything relevant > either, but at least it doesn't error unnecessarily: > > handyrep@john:~/handyrep$ pg_isready -h john -p 5432 -U no_such_user > john:5432 - accepting connections > > The attached patch fix it. Regards, -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog sobre TI: http://fabriziomello.blogspot.com >> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello >> Twitter: http://twitter.com/fabriziomello
diff --git a/src/bin/scripts/pg_isready.c b/src/bin/scripts/pg_isready.c index d27ccea..7568df5 100644 --- a/src/bin/scripts/pg_isready.c +++ b/src/bin/scripts/pg_isready.c @@ -130,7 +130,7 @@ main(int argc, char **argv) /* * Get the host and port so we can display them in our output */ - if (pgdbname) + if (pgdbname && strchr(pgdbname, '=') != NULL) { opts = PQconninfoParse(pgdbname, &errmsg); if (opts == NULL)
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers