On Mon, Nov 18, 2013 at 3:21 PM, Bruce Momjian <br...@momjian.us> wrote:
> On Thu, Nov  7, 2013 at 02:40:17PM -0500, Peter Eisentraut wrote:
>> On 11/7/13, 1:00 PM, Josh Berkus wrote:
>> > If we wanted to change the defaults, I think it would be easier to
>> > create a separate bin name (e.g. pg_backup) than to change the existing
>> > parameters for pg_dump.
>>
>> Note the following code in pg_dump.c:
>>
>>     /* Set default options based on progname */
>>     if (strcmp(progname, "pg_backup") == 0)
>>         format = "c";
>
> Wow, when was that added?  git blame says 2002:
>
>   9f0ae0c8 (Tom Lane           2002-05-10 22:36:27 +0000   387)   /* Set 
> default options based on progname */
>   9f0ae0c8 (Tom Lane           2002-05-10 22:36:27 +0000   388)   if 
> (strcmp(progname, "pg_backup") == 0)
>   9f0ae0c8 (Tom Lane           2002-05-10 22:36:27 +0000   389)       format 
> = "c";
>
> However, pggit log 9f0ae0c82060e3dcd1fa7ac8bbe35a3f9a44dbba does not
> show that line being added by the diff.

I dunno what your pggit script does, but "git log" doesn't normally
show the diff at all.  "git show
9f0ae0c82060e3dcd1fa7ac8bbe35a3f9a44dbba", however, does show that
line being added.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to