On Fri, Oct 04, 2013 at 10:42:32AM +0200, Karol Trzcionka wrote: > W dniu 04.10.2013 02:51, Robert Haas pisze: > > Do you have a link to previous discussion on the mailing list? > Sorry, most of discussion was at IRC channel. > > I'm not positive there's enough information available > > at that stage, but if p_target_rangetblentry is populated at that > > point, you should be able to make AFTER.x translate to a Var > > referencing that range table entry. > It's not enough. Even if we know "where we are", there are more issues. > The main question is: how should we pass information about "hello, I'm > specific Var, don't evaluate me like others"? We can add two fields to > Var structure (flag - normal/before/after and no. column) - however it > needs to modify copyObject for Vars (at now it's done e.g. in > flatten_join_alias_vars_mutator for varoattno and varnoold). If > copyObject is modified, sure code in > flatten_join_alias_vars_mutator/pullup_replace_vars_callback will be > useless. I don't know if modifying pg at the low-level (changing > structure of Var and behaviour of copyObject) is good idea. Yes if the > community really want it but it needs more "votes". There is "medium" > solution: changing Var structure and do the "copy" like now (in mutator > and callback) but w/o the condition statement (for the new fields). I > think it might need to modify more places in code because of "comparing" > vars (maybe we'd need to include new fields while comparision). > Regards, > Karol Trzcionka
Karol, Do you plan to continue this work for the current commitfest? A lot of people really want the feature :) Cheers, David. -- David Fetter <da...@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fet...@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers