On Wed, 2013-11-20 at 22:41 +0900, Michael Paquier wrote: > Here are a couple of comments about the patch: > 1) I think that you should regenerate ./configure as well with this > patch to include all the changes together (someone correct me if I am > wrong here!)
Doesn't matter either way. > 2) This new option should be added in the section "## Command line > options" in configure.in Yes. > 3) PG_VERSION is not a variable name adapted IMO, as it might contain > custom information. Something like PG_VERSION_TOTAL perhaps? I don't think it's necessary to split this up further. We have PG_VERSION and PG_MAJORVERSION. What's the use for one more level? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
