On 11/21/13, 5:04 AM, Atri Sharma wrote: > Please find attached the latest patch for WITHIN GROUP. This patch is > after fixing the merge conflicts.
I would like to see more explanations and examples in the documentation. You introduce this feature with "Ordered set functions compute a single result from an ordered set of input values." But string_agg, for example, does that as well, so it's not clear how this is different. Between ordered aggregates, window functions, and this new feature, it can get pretty confusing. Also, the "hypothetical" part should perhaps be explained in more detail. The tutorial part of the documentation contains a nice introduction to window function. I suggest you add something like that as well. In func.sgml, please list the functions in alphabetical order. Also, don't write "should" when you mean "must". -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
