On 2013-12-10 19:11:03 -0500, Robert Haas wrote: > Committed #1 (again).
Thanks! > Regarding this: > > + /* XXX: we could also do this unconditionally, the space is used > anyway > + if (copy_oid) > + HeapTupleSetOid(key_tuple, HeapTupleGetOid(tp)); > > I would like to put in a big +1 for doing that unconditionally. I > didn't make that change before committing, but I think it'd be a very > good idea. Ok. I wasn't sure if it wouldn't be wierd to include the oid in the tuple logged for a replica identity that doesn't cover the oid. But the downside is pretty small... Will send a patch. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
