Re: [HACKERS] [9.3 bug] disk space in pg_xlog increases during archive recovery

[MauMau]

From: "Fujii Masao" <masao.fu...@gmail.com>

!     if (source == XLOG_FROM_ARCHIVE && StandbyModeRequested)

Even when standby_mode is not enabled, we can use cascade replication and

should be added into this condition.

!       snprintf(recoveryPath, MAXPGPATH, XLOGDIR "/RECOVERYXLOG");
!       XLogFilePath(xlogpath, ThisTimeLineID, endLogSegNo);
!
!       if (restoredFromArchive)


here?

it needs the accumulated WAL files. So I think that AllowCascadeReplication() Don't we need to check !StandbyModeRequested and !AllowCascadeReplication()

Oh, you are correct.  Okay, done.

!               /*

!                * RECOVERYXLOG laying about, get rid of it.
!                */
!               unlink(recoveryPath);   /* ignore any error */


you can refactor that.

! * If the latest segment is not archival, but there's still a The similar line exists in the lower side of exitArchiveRecovery(), so ISTM that

-  /*
-   * Since there might be a partial WAL segment named RECOVERYXLOG, get rid
-   * of it.
-   */
-  snprintf(recoveryPath, MAXPGPATH, XLOGDIR "/RECOVERYXLOG");
-  unlink(recoveryPath);  /* ignore any error */
-



Regards
MauMau

That's already done in the previous patch: deletion of RECOVERYXLOG was moved into else clause, as in:

wal_increase_in_pitr_v2.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers