Hi, On 2014-01-16 11:25:59 -0300, Alvaro Herrera wrote: > Eyeballing this patch, three thoughts: > > 1. I wonder whether ilist.c/h should be moved to src/common so that > frontend code could use it.
Sounds like a good idea. There's some debugging checks that elog, but that should be fixable easily. > 2. I wonder whether ilist.c should gain the ability to have > singly-linked lists with a pointer to the tail node for appending to the > end. This code would use it, and also the code doing postgresql.conf > parsing which has head/tail pointers all over the place. I'm sure there > are other uses. I am not generaly adverse to it, but neither of those usecases seems to warrant that. They just should use a doubly linked list, it's not like the memory/runtime overhead is significant. And the implementation overhead doesn't count either if they use ilist.h. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
