Robert Haas escribió: > I don't think there's any real reason to defined > PG_AUTOCONF_FILENAME_TEMP. pg_stat_statements just writes > PGSS_DUMP_FILE ".tmp" and that hasn't been a problem that I know of. > I do wonder why ALTER SYSTEM SET is spelling the suffix "temp" instead > of "tmp".
I agree with Michael that having pg_basebackup be aware of the ".temp" suffix is ugly; for instance if we were to fix it to ".tmp" in ALTER SYSTEM but forgot to change pg_basebackup, the check would be immediately broken. But on the other hand I'm not sure why it's such a problem for pg_basebackup that it needs to be checking in the first place -- how about we rip that out? Perhaps the temp file needs to be in pgsql_tmp? (Do we need to worry about cross-filesystem links if we do? I mean, do we support mounting pgsql_tmp separately?) -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
