On Mon, Jul 1, 2013 at 08:10:14PM -0400, Josh Kupershmidt wrote: > On Thu, Jun 27, 2013 at 11:47 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > > On Thu, Jun 27, 2013 at 10:36 AM, Josh Kupershmidt <schmi...@gmail.com> > > wrote: > >> On Wed, Jun 26, 2013 at 12:22 PM, Fujii Masao <masao.fu...@gmail.com> > >> wrote: > >>> Though this is a corner case, the patch doesn't seem to handle properly > >>> the case > >>> where "-D" appears as other option value, e.g., -k option value, in > >>> postmaster.opts > >>> file. > >> > >> Could I see a command-line example of what you mean? > > > > postmaster -k "-D", for example. Of course, it's really a corner case :) > > Oh, I see. I was able to trip up strip_datadirs() with something like > > $ PGDATA="/my/data/" postmaster -k "-D" -S 100 & > $ pg_ctl -D /my/data/ restart > > that example causes pg_ctl to fail to start the server after stopping > it, although perhaps you could even trick the server into starting > with the wrong options. Of course, similar problems exists today in > other cases, such as with the relative paths issue this patch is > trying to address, or a datadir containing embedded quotes. > > I am eager to see the relative paths issue fixed, but maybe we need to > bite the bullet and sort out the escaping of command-line options in > the rest of pg_ctl first, so that a DataDir like "/tmp/here's a \" > quote" can consistently be used by pg_ctl {start|stop|restart} before > we can fix this wart.
Where are we on this patch? -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers